Region does not re-delegateEvent on previously closed view

[diwu1989]

This is a fix for #651

Region.show will call delegateEvents on the view if the view is one that was previously closed.

Test included.

[diwu1989]

Any comments? Would appreciate this getting merged in and released, I'd like to be running off of mainline marionette instead of my monkey-patched marionette. Thanks.

[jabberfest]

Looks like a dup. of this except you made a pull request :-) I hope it gets accepted. +1 for this

#622

[diwu1989]

Yeah, I think this definitely should go in, or else the documentation for Region should be updated to reflect that the UI, event, and model bindings will need to re-delegated manually.

[firetix]

I was struggling with this for the past few days, this is awesome really need to be integrated

[andrewhubbs]

👍 Been dealing with this same issue. Would love to see this merged in.

[diwu1989]

If anyone is feeling adventurous:
https://raw.github.com/diwu1989/backbone.marionette/rebuildWithRegionFix/lib/backbone.marionette.js

I rebased this pull request off of the current head of Dev, and then rebuilt with the fix into that other branch.

[nrako]

Is this PR the right way to fix this @derickbailey ?

[jabberfest]

Looks like he fixed this in 1.1 with his own fix? This is a quote from the v1.10 change log released a few days ago.

v1.1 view commit logs

Marionette.View / All Views

Fix for ui bindings to not be removed from view prototype, if unrendered view is closed

[diwu1989]

I don't think that commit log message is the same problem. Specifically, try this jsfiddle:
http://jsfiddle.net/X9PE6/6/

It's pointing towards the latest 1.1 build and it still doesn't work.

[farias-r7]

Yea you're right. I didn't test what I was thinking when I wrote that. Maybe we can get some feedback from @derickbailey

[paynecodes]

👍 for this. I'm having trouble with ui hash events upon closing and reopening the view. For now, I'm adding the selector onRender like so:

onRender: function() {
  this.$shouldBeUI = $('#some-id');
}

This is what I was using before realizing that this.ui.shouldBeUI wasn't available after navigating to and fro and bit.

ui: {
  'shouldBeUI': '#some-id'
}

[samccone]

only commit this change, not all the whitespace changes

[samccone]

👍 once the whitespace stuff is fixed

[ccamarat]

@jpdesigndev I published a fix for the UI issue about a month ago; is it in your codebase, and are you still seeing that problem? #686

[samccone]

@diwu1989 is this still active?

[cobbweb]

I think the semantics of this are wrong. Isn't close suppose to be a destructive method to ready the view for garbage collection?? If #724 make it in, this would be more obvious.

A better fix here would be a new method on Marionette.ItemView that 'closes' a view in a way that allows it to be shown/opened again (and therefore not ready for garbage collection). Or just re-make the view and show that instead.

[samccone]

yeah @cobbweb I agree with you it seems like several of these PR's are really just trying to fix what #724 does.

I was just checking to see if @diwu1989 had any comments or interest in the PR.

[diwu1989]

If the other PR fixes this issue, then please just go ahead with that one.

Thanks!