New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Region does not re-delegateEvent on previously closed view #654
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
// Region | ||
// Region | ||
// ------ | ||
// | ||
// Manage the visual regions of your composite application. See | ||
|
@@ -53,19 +53,19 @@ _.extend(Marionette.Region, { | |
} | ||
|
||
var selector, RegionType; | ||
|
||
// get the selector for the region | ||
|
||
if (regionIsString) { | ||
selector = regionConfig; | ||
} | ||
} | ||
|
||
if (regionConfig.selector) { | ||
selector = regionConfig.selector; | ||
} | ||
|
||
// get the type for the region | ||
|
||
if (regionIsType){ | ||
RegionType = regionConfig; | ||
} | ||
|
@@ -77,7 +77,7 @@ _.extend(Marionette.Region, { | |
if (regionConfig.regionType) { | ||
RegionType = regionConfig.regionType; | ||
} | ||
|
||
// build the region instance | ||
var region = new RegionType({ | ||
el: selector | ||
|
@@ -132,7 +132,12 @@ _.extend(Marionette.Region.prototype, Backbone.Events, { | |
if (isDifferentView || isViewClosed) { | ||
this.open(view); | ||
} | ||
|
||
|
||
if (isViewClosed) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. only commit this change, not all the whitespace changes |
||
// this is a view that was closed, events need to be re-delegated | ||
view.delegateEvents(); | ||
} | ||
|
||
this.currentView = view; | ||
|
||
Marionette.triggerMethod.call(this, "show", view); | ||
|
@@ -172,8 +177,8 @@ _.extend(Marionette.Region.prototype, Backbone.Events, { | |
delete this.currentView; | ||
}, | ||
|
||
// Attach an existing view to the region. This | ||
// will not call `render` or `onShow` for the new view, | ||
// Attach an existing view to the region. This | ||
// will not call `render` or `onShow` for the new view, | ||
// and will not replace the current HTML for the `el` | ||
// of the region. | ||
attachView: function(view){ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for this change in the commit