Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PropertyMetadata's Description #365

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Conversation

juampi92
Copy link
Contributor

@juampi92 juampi92 commented Apr 22, 2024

This PR will add the description property for a table's property.

I don't know how recent Notion added this feature, but I noticed it only one or two months ago.

Here is the API documentation about it, and here is how it looks in Notion's UI:
image

The API will not send the description if it was not filled, so I tried to follow the same behaviour when doing toArray().
image

I couldn't find anything that would make it backwards incompatible, and the fact that all existing tests pass is a good hint I guess.
Let me know if something is missing!

@mariosimao mariosimao merged commit 62ea25d into mariosimao:main Apr 22, 2024
4 of 6 checks passed
@mariosimao
Copy link
Owner

@juampi92 thank you very much for your contribution. The latest release at version 1.14.0 now contains support to property description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants