Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Isolation" parameter for docker create #164

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Add "Isolation" parameter for docker create #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d86ef1d
Add "Isolation" parameter for docker create
sqeezy Oct 5, 2020
8ee4f74
Add missing space in front of new parameter
sqeezy Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Ductus.FluentDocker.Tests/Model/Containers/ContainerCreateParamsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,16 @@ public void NvidiaRuntimeGeneratesRuntimeOption()
var opts = prms.ToString();
Assert.IsTrue(opts.Contains(" --runtime=nvidia"));
}

[DataTestMethod]
[DataRow(ContainerIsolationTechnology.Hyperv, "hyperv")]
[DataRow(ContainerIsolationTechnology.Process, "process")]
[DataRow(ContainerIsolationTechnology.Default, "default")]
public void ContainerIsolationGeneratesRuntimeOption(ContainerIsolationTechnology isolationTechnology, string expectedIsolationParameter)
{
var prms = new ContainerCreateParams { Isolation = isolationTechnology};
var opts = prms.ToString();
Assert.IsTrue(opts.Contains($" --isolation {expectedIsolationParameter}"));
}
}
}
17 changes: 15 additions & 2 deletions Ductus.FluentDocker/Model/Containers/ContainerCreateParams.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ public sealed class ContainerCreateParams
/// When set to true, independand on the HEALTHCHECK in the Dockerfile, no health check is performed.
/// </summary>
/// <remarks>
/// --no-healthcheck
/// --no-healthcheck
/// </remarks>
public bool HealthCheckDisabled { get; set; }
/// <summary>
Expand Down Expand Up @@ -653,6 +653,14 @@ public sealed class ContainerCreateParams
/// </remarks>
public string[] Labels { get; set; }

/// <summary>
/// Container isolation technology
/// </summary>
/// <remarks>
/// --isolation
/// </remarks>
public ContainerIsolationTechnology Isolation { get; set; }

/// <summary>
/// Add additional groups to join
/// </summary>
Expand Down Expand Up @@ -931,6 +939,11 @@ public override string ToString()
if (Runtime != ContainerRuntime.Default)
sb.Append($" --runtime={Runtime.ToString().ToLower()}");

var isolation = Isolation.ToDocker();
if (null != isolation)
{
sb.Append($" --isolation {Isolation.ToDocker()}");
}
return sb.ToString();
}
}
Expand All @@ -947,7 +960,7 @@ public override string ToString()
--mac-address Container MAC address (e.g. 92:d0:c6:0a:29:33)
--net=default Connect a container to a network
--net-alias=[] Add network-scoped alias for the container
--oom-score-adj Tune host's OOM preferences (-1000 to 1000)
--oom-score-adj Tune host's OOM preferences (-1000 to 1000)
--read-only Mount the container's root filesystem as read only
--security-opt=[] Security Options
--shm-size Size of /dev/shm, default value is 64MB
Expand Down