Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicating trigger source #73

Closed
arvanus opened this issue Aug 22, 2020 · 12 comments
Closed

Duplicating trigger source #73

arvanus opened this issue Aug 22, 2020 · 12 comments
Labels
bug Firebird 3 Firebird 3 Related

Comments

@arvanus
Copy link
Collaborator

arvanus commented Aug 22, 2020

@Jdochoa always when I recompile an trigger, its source code gets duplicated in the trigger part
This occurs only in your code, can you take an look?
image

Steps to reproduce:
Open any (table) trigger
Click on Source "Edit"
Run code
Check trigger Summary again, it's already wrong
Just to check, if you click "Edit" it's wrong
Thanks

@arvanus arvanus added bug Firebird 3 Firebird 3 Related labels Aug 22, 2020
@arvanus
Copy link
Collaborator Author

arvanus commented Aug 22, 2020

@Jdochoa another bug:
image
No database triggers found at database triggers property

@Jdochoa
Copy link
Contributor

Jdochoa commented Aug 24, 2020

@Jdochoa another bug:
image
No database triggers found at database triggers property

@arvanus I planning about remove this.
What do you think?

@Jdochoa
Copy link
Contributor

Jdochoa commented Aug 24, 2020

@Jdochoa always when I recompile an trigger, its source code gets duplicated in the trigger part
This occurs only in your code, can you take an look?
image

Steps to reproduce:
Open any (table) trigger
Click on Source "Edit"
Run code
Check trigger Summary again, it's already wrong
Just to check, if you click "Edit" it's wrong
Thanks

Fixed up

@arvanus
Copy link
Collaborator Author

arvanus commented Aug 24, 2020

@Jdochoa another bug:
image
No database triggers found at database triggers property

@arvanus I planning about remove this.
What do you think?

Well I think that for an consistency behavior, it's better to keep it here too.
Exactly like in the tables where you have an Trigger tab, in your database you have triggers too, so I would consider to be consistent to keep then in this tab too

@arvanus
Copy link
Collaborator Author

arvanus commented Aug 24, 2020

@Jdochoa I'd ask you, to if possible to focus in one feature at time, this way I can test and publish as soon as possible.
Lets build an chronogram or something like that? This way I can help you too if I know what you are working at, what do you think?

@luronumen
Copy link

I agree with @arvanus .
Let's first focus on fixing all known bugs and then move on to implementing new features.

@Jdochoa
Copy link
Contributor

Jdochoa commented Aug 28, 2020

Hi @luronumen, @arvanus, @mariuz
I completely agree with you.
What do you think if defined a roadmap and assigned a responsible for each issue?
The features in i worked are:

  • Database:
    • SQL Security
    • Linger
  • Procedures:
    • Hide procedures from packages.
    • UDR functionality.
    • SQL Security
  • Functions:
    • Hide functions from packages.
    • UDR functionality.
    • Separate UDF.
    • PSQL Functions.
    • SQL Security
  • Domains:
    • separate sysdomain.
  • Triggers:
    • Separate DDL Triggers.
    • Separate DB Triggers.
    • SQL Security
  • Tables:
    • Separatte GTT.
    • SQL Security
  • Packages:
    • Basic functionality.
    • SQL Security

I wi'll worker in:

  • Database:
    • Replication.
  • Functions:
    • Finish functionality.
  • Packages:
    • Finish functionality.
    • Agregate syspackages.
  • Index.
    • Add index node.
  • Domains:
    • Upgrade functionality.
  • Tables:
    • Agregate Identity columns.
    • Complete functionality GTT.
    • Replication.
  • FB 4 DataTypes

Doy you have a list from bugs?

@Jdochoa
Copy link
Contributor

Jdochoa commented Aug 28, 2020

@Jdochoa another bug:
image
No database triggers found at database triggers property
Fix it.

@luronumen
Copy link

Hi @Jdochoa

Excellent roadmap that you created. I find it very interesting if we can continue with this planning.
Please notify me when the bugs / features you are working on are ready for testing. I can help you with this activity before a new version is released.

Thank you very much for your dedication to this project as one of the best Firebird Admin in the world.

Best Regards,
Luciano

Jdochoa added a commit to Jdochoa/flamerobin that referenced this issue Mar 1, 2021
- Some fixes DB Trigger, DML Trigger and DDL Trigger mariuz#48, mariuz#70, mariuz#73 and  mariuz#154
- Some fixes Package implementation mariuz#55
- Unable to change Field Datatype mariuz#165
- "Functions" and "Global Temporaries" context popup menu mariuz#162
- Index node experimental.
- Initial implementation node users mariuz#149
@Jdochoa
Copy link
Contributor

Jdochoa commented Jun 21, 2021

Hi @arvanus
Can you give me feedback on this or close it?

Thanks
./jo

@arvanus
Copy link
Collaborator Author

arvanus commented Jun 21, 2021

Done, just lets organize what is pending for the next stable release? (not snapshot) 0.9.4

@arvanus arvanus closed this as completed Jun 21, 2021
@Jdochoa
Copy link
Contributor

Jdochoa commented Jun 21, 2021

Done, just lets organize what is pending for the next stable release? (not snapshot) 0.9.4

Please view Roadmap #216

:/jo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Firebird 3 Firebird 3 Related
Projects
None yet
Development

No branches or pull requests

3 participants