Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DDL triggers #70

Closed
arvanus opened this issue Aug 21, 2020 · 5 comments
Closed

Add support for DDL triggers #70

arvanus opened this issue Aug 21, 2020 · 5 comments

Comments

@arvanus
Copy link
Collaborator

arvanus commented Aug 21, 2020

Relates to #48
Add support for DDL triggers, example:

SET TERM ^ ;
create trigger trig_ddl_sp before CREATE PROCEDURE
as
begin
end!
SET TERM ; ^

Get extracted as

SET TERM ^ ;
CREATE OR ALTER TRIGGER TRIG_DDL_SP ACTIVE
AFTER  OR UPDATE POSITION 0
as
begin
end^
SET TERM ; ^

Needs to get RDB$TRIGGERS.RDB$TRIGGER_TYPE complete documentation to fix

Trigger::FiringTime Trigger::getFiringTime(int type)

And:
wxString Trigger::getAlterSql()

And who knows where else 👍

@Jdochoa
Copy link
Contributor

Jdochoa commented Aug 22, 2020

This task is very complex, because rdb$types not defined this rdb$trigger_type.
I'm separated DB Trigger, DDL Trigger and Trigger, but can't generate script for DDL Trigger.
See https://github.com/Jdochoa/flamerobin/tree/FB3

@arvanus
Copy link
Collaborator Author

arvanus commented Aug 22, 2020

Yeah, I could't find any docs about it, maybe ask at https://groups.google.com/g/firebird-support
Good to see you here @Jdochoa!
I'm doing some bug-hunting here, soon I'll push some new patches and a new feature like #69

@Jdochoa
Copy link
Contributor

Jdochoa commented Aug 22, 2020

Yeah, I could't find any docs about it, maybe ask at https://groups.google.com/g/firebird-support
Good to see you here @Jdochoa!
I'm doing some bug-hunting here, soon I'll push some new patches and a new feature like #69

Hi @arvanus you need see
https://github.com/FirebirdSQL/firebird/blob/2964fdd6349134030580dd35ae970c16d34e76e1/src/isql/show.epp#L314-L345
to complete this.

Jdochoa added a commit to Jdochoa/flamerobin that referenced this issue Mar 1, 2021
- Some fixes DB Trigger, DML Trigger and DDL Trigger mariuz#48, mariuz#70, mariuz#73 and  mariuz#154
- Some fixes Package implementation mariuz#55
- Unable to change Field Datatype mariuz#165
- "Functions" and "Global Temporaries" context popup menu mariuz#162
- Index node experimental.
- Initial implementation node users mariuz#149
@luronumen
Copy link

Hi @arvanus,

Is this issue still reproducible in 0.9.3.8 Snapshot version?

@arvanus
Copy link
Collaborator Author

arvanus commented Jun 7, 2021

It's working now

@arvanus arvanus closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants