New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for Firebord v3 boolean #8

Merged
merged 7 commits into from Nov 16, 2016

Conversation

Projects
None yet
2 participants
@Tutul-
Contributor

Tutul- commented Nov 15, 2016

Remove error whean trying to display a table with native boolean
Add possibility to GET or SET
Display correct type in table properties

WARNING: it's only a fast patch to ensure you can use it. It required probably more work for a better code ;)

Tutul- added some commits Nov 14, 2016

Add BOOLEAN minimal support for v3
+ Remove error when a boolean is fetched

TODO:
+ Set
+ Get
+ Display
* Convert string <-> bool
Boolean support for SET
+ Add SET support for boolean (firebird v3)

You can add row now ^^

* Pseudo support for GET but not visible (why ?)

TODO:
+ ColType dislay (1) (probably for <type>(<size>) from string)!
Basic boolean GET support
+ Boolean display in flamerobin now
/!\ It's an ugly code bloc in string
    Must probably create a seperate row defintion (chiled of string ?)
    But for now it's working

TODO:
Only 1 thing left before optimization and correction for PULL REQUEST
+ Type not display in properties

@mariuz mariuz merged commit 6a6dd4d into mariuz:master Nov 16, 2016

@mariuz

This comment has been minimized.

Show comment
Hide comment
@mariuz

mariuz Nov 16, 2016

Owner

Thank you , merged ;)

Owner

mariuz commented Nov 16, 2016

Thank you , merged ;)

@Tutul-

This comment has been minimized.

Show comment
Hide comment
@Tutul-

Tutul- Nov 16, 2016

Contributor

I just see an error when using "add row" button, I'll fixing it these evening (probably). It's only the statement bulder take a string like 'true'/' false' instead of true or false. My bad ^^'

Contributor

Tutul- commented Nov 16, 2016

I just see an error when using "add row" button, I'll fixing it these evening (probably). It's only the statement bulder take a string like 'true'/' false' instead of true or false. My bad ^^'

@Tutul-

This comment has been minimized.

Show comment
Hide comment
@Tutul-

Tutul- Nov 16, 2016

Contributor

Seem to be working... Don't know why I've got an error. :)
If you want, I'm trying to build release for Linux-x86, Linux-x86_64 and Windows (maybe OSX later)
Check https://github.com/Tutul-/flamerobin/releases/tag/0.9.4

Contributor

Tutul- commented Nov 16, 2016

Seem to be working... Don't know why I've got an error. :)
If you want, I'm trying to build release for Linux-x86, Linux-x86_64 and Windows (maybe OSX later)
Check https://github.com/Tutul-/flamerobin/releases/tag/0.9.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment