Allow blocks on Faraday connections

lib/faraday_bang/bang.rb

@@ -1,22 +1,33 @@
 module Faraday::Bang
   ERROR_CODES = [(400..417).to_a, (500..505).to_a].flatten
+  SUPPORTED_HTTP_METHODS = Faraday::Connection::METHODS - Set.new([ :options ])
 
-  Faraday::Connection::METHODS.each do |verb|
-    define_method("#{verb}!") do |*args|
-      response = self.send(verb, *args)
-      if response.status >= 400
-        err_name = "Response#{response.status}Error"
-        if Faraday::Bang.const_defined?(err_name)
-          klass = Faraday::Bang.const_get(err_name)
-          raise klass.new(response)
-        else
-          raise Faraday::Bang::ResponseError.new(response)
-        end
-      end
-      return response
+  SUPPORTED_HTTP_METHODS.each do |verb|
+    define_method("#{verb}!") do |*args, &block|
+      response = self.send(verb, *args, &block)
+      handle_error(response)
     end
   end
 
+  define_method("options!") do |*args, &block|
+    url, params, headers = args
+    response = run_request(:options, url, params, headers, &block)
+    handle_error(response)
+  end
+
+  private
+  def handle_error(response)
+    if response.status >= 400
+      err_name = "Response#{response.status}Error"
+      if Faraday::Bang.const_defined?(err_name)
+        klass = Faraday::Bang.const_get(err_name)
+        raise klass.new(response)
+      else
+        raise Faraday::Bang::ResponseError.new(response)
+      end
+    end
+    response
+  end
 end
 
 Faraday.extend(Faraday::Bang)

test/lib/faraday_bang/bang_test.rb

@@ -8,7 +8,14 @@
 
   [Faraday, Faraday.new].each do |klass|
 
-    Faraday::Connection::METHODS.each do |verb|
+    Faraday::Bang::SUPPORTED_HTTP_METHODS.each do |verb|
+
+      it "##{verb}! passes a block" do
+        block = Proc.new do |req|
+          raise "dummy error #{verb}"
+        end
+        ->{ klass.send("#{verb}!", &block) }.must_raise RuntimeError
+      end
 
       describe "##{verb}!" do