AppEngine compatibility fix #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing a hard-coded `oath2.NoContext` to `oauth2.Config.Exchange` breaks AppEngine compatibility following recent changes to golang/appengine and golang/oauth2 to use context.Context (see: golang.org/x/net/context). Allowing a context to be passed through `gothic.CompleteUserAuth` / `Session.Authorize` allows a context to be supplied, e.g.: ctx := appengine.NewContext(req) user, err := gothic.CompleteUserAuth(ctx, res, req) Even if not running on AppEngine, the context is still useful to allow providers to handle timeouts / cancellation but context.TODO() can be passed for the time being.
|
I'll look at adding support a different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a hard-coded
oath2.NoContexttooauth2.Config.Exchangebreaks AppEngine compatibility following recent changes to golang/appengine and golang/oauth2 to use context.Context (see: golang.org/x/net/context).Allowing a context to be passed through
gothic.CompleteUserAuth/Session.Authorizeallows a context to be supplied, e.g.:ctx := appengine.NewContext(req)
user, err := gothic.CompleteUserAuth(ctx, res, req)
Even if not running on AppEngine, the context is still useful to allow providers to handle timeouts / cancellation but context.TODO() can be passed for the time being.