Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppEngine compatibility fix #30

Closed
wants to merge 2 commits into from
Closed

AppEngine compatibility fix #30

wants to merge 2 commits into from

Commits on Mar 22, 2015

  1. AppEngine compatibility fix 

    Passing a hard-coded `oath2.NoContext` to `oauth2.Config.Exchange` breaks AppEngine compatibility following recent changes to golang/appengine and golang/oauth2 to use context.Context (see: golang.org/x/net/context).
Allowing a context to be passed through `gothic.CompleteUserAuth` / `Session.Authorize` allows a context to be supplied, e.g.:

ctx := appengine.NewContext(req)
user, err := gothic.CompleteUserAuth(ctx, res, req)

Even if not running on AppEngine, the context is still useful to allow providers to handle timeouts / cancellation but context.TODO() can be passed for the time being.
    @CaptainCodeman
    CaptainCodeman committed Mar 22, 2015
    Configuration menu
    Copy the full SHA
    61da6c0 View commit details
    Browse the repository at this point in the history

  2. Missed test

    @CaptainCodeman
    CaptainCodeman committed Mar 22, 2015
    Configuration menu
    Copy the full SHA
    8845b41 View commit details
    Browse the repository at this point in the history