Refactor to use own Error type in the library api #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failure (tests) seems unrelated? |
|
Thanks! I might tweak some of the error messages, but this looks like a good improvement. |
|
The test problems were in the That's introduces some conflicts. Can you rebase onto master so I can merge? |
Using anyhow in a library's public interface is not recommended mainly as it makes it tough to integrate with other libraries or existing applications which may not use anyhow themselves, chiefly due to anyhow::Error not implementing std::error::Error itself. This commit instead refactors the code to use several thiserror[1]-derived Error types and completely eliminates anyhow from library code. It is still used as the output error library in the sp and spp executables, though. [1]: https://docs.rs/thiserror
|
Rebased! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it's a library crate, having Anyhow as its error type makes it harder to integrate with anything that's not using Anyhow itself (chiefly due to it not implementing
std::error::Error).This PR refactors the code to use several thiserror-derived Error types and completely eliminates anyhow from library code.
It leaves anyhow as the output error library in the sp and spp executables, though.
The only holdover is an error variant which wraps anyhow when it comes from termwiz, and I'm also working on refactoring that crate to expose its own error type: wez/wezterm#406