Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching termwiz to thiserror instead of anyhow #406

Closed
passcod opened this issue Dec 29, 2020 · 2 comments
Closed

Switching termwiz to thiserror instead of anyhow #406

passcod opened this issue Dec 29, 2020 · 2 comments
Labels
enhancement New feature or request termwiz

Comments

@passcod
Copy link
Contributor

passcod commented Dec 29, 2020

Would you be open to switching the error type of the termwiz crate from Anyhow to some custom type (e.g. with thiserror)? I'm happy to do the work for it.

As it's a library crate, it makes it hard to integrate with anything that's not using anyhow itself.
@passcod passcod added the enhancement New feature or request label Dec 29, 2020
@wez wez added the termwiz label Dec 29, 2020
@wez
Copy link
Owner

wez commented Dec 29, 2020

I'll gladly take a PR that does that; thanks!

This was referenced Dec 29, 2020
Merged
Closed
wez added a commit that referenced this issue Jan 8, 2021
@wez
termwiz: Remove anyhow::Result from public API
5d360ae 
It's been replaced with an opaque termwiz error type instead.

This is a bit of a more conservative approach than that in (refs: #407)
and has less of an impact on the surrounding code, which appeals to
me from a maintenance perspective.

refs: #406
refs: #407
@passcod passcod closed this as completed Jan 11, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request termwiz
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wez @passcod