Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed insecure protocol warnings #72

Closed
wants to merge 1 commit into from

Conversation

markcheret
Copy link
Owner

No description provided.

@lolzim
Copy link
Contributor

lolzim commented Apr 12, 2021

Question could be: should we have a Flash link, either in http or https ?!

@Rumperuu
Copy link
Collaborator

Question could be: should we have a Flash link, either in http or https ?!

Hahaha, my thoughts exactly!

@markcheret
Copy link
Owner Author

There is some decluttering to do for sure

@Rumperuu
Copy link
Collaborator

Rumperuu commented Apr 13, 2021

There is some decluttering to do for sure

For sure — jQuery Tools 1.2.7 came out in 2012 and targets jQuery 1.7.1 (jQuery is currently on 3.6.0!)

Copy link
Collaborator

@Rumperuu Rumperuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @lolzim and my comments, I think we should leave this as it is (close the PR without merging) and instead focus on refactoring out the jQuery Tools dependency entirely as a priority task (#85).

@Rumperuu Rumperuu mentioned this pull request Apr 14, 2021
@lolzim
Copy link
Contributor

lolzim commented Apr 14, 2021

OK for me. Mark talked about github tools for dev management, maybe it's time to test 'em. Tasks split then distribution could be a way.

@markcheret
Copy link
Owner Author

closing, as #85 will fix this in-depth of just a quick fix.

@markcheret markcheret closed this Apr 14, 2021
@markcheret markcheret deleted the insecure-protocols-warning branch April 14, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants