Fix matchStart for incomplete links

markdown-it · May 2, 2022 · d03a760 · d03a760
1 parent 95c261b
commit d03a760
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+4.0.1 / WIP
+------------------
+
+- Fix `http://` incorrectly returned as a link by matchStart.
+
+
 4.0.0 / 2022-04-22
 ------------------
 

diff --git a/index.js b/index.js
@@ -588,11 +588,11 @@ LinkifyIt.prototype.matchAtStart = function matchAtStart(text) {
   if (!m) return null;
 
   var len = this.testSchemaAt(text, m[2], m[0].length);
-  if (len) {
-    this.__schema__     = m[2];
-    this.__index__      = m.index + m[1].length;
-    this.__last_index__ = m.index + m[0].length + len;
-  }
+  if (!len) return null;
+
+  this.__schema__     = m[2];
+  this.__index__      = m.index + m[1].length;
+  this.__last_index__ = m.index + m[0].length + len;
 
   return createMatch(this, 0);
 };

diff --git a/test/test.js b/test/test.js
@@ -306,4 +306,12 @@ describe('API', function () {
     assert.ok(!l.matchAtStart(str));
     assert.strictEqual(l.match(str).length, 2);
   });
+
+  it('should not match incomplete links', function () {
+    // regression test for https://github.com/markdown-it/markdown-it/issues/868
+    var l = linkify();
+
+    assert.ok(!l.matchAtStart('http://'));
+    assert.ok(!l.matchAtStart('https://'));
+  });
 });