Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unicode emoji characters, allowing them to be customized by renderer rules #53

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Replace unicode emoji characters, allowing them to be customized by renderer rules #53

wants to merge 3 commits into from

Commits on May 13, 2024

  1. Replace unicode emoji characters, allowing them to also be customized… 

    … by renderer rules
    @carter-thaxton
    carter-thaxton committed May 13, 2024
    Configuration menu
    Copy the full SHA
    9187c7a View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Fix linter errors and code-coverage warnings 

    Use enforced code style for spaces.
The code coverage checker was complaining about the 'unnecessary' check that I added in the previous commit, in case the replacement regexp didn't match anything.
    @carter-thaxton
    carter-thaxton committed May 14, 2024
    Configuration menu
    Copy the full SHA
    06e6263 View commit details
    Browse the repository at this point in the history

  2. Add some tests to handle overrides of markdownit().renderer.rules.emoji 

    Specifically, add a test that emojies using unicode characters are also wrapped by such renderer rules,
covering the new behavior in this pull request.
    @carter-thaxton
    carter-thaxton committed May 14, 2024
    Configuration menu
    Copy the full SHA
    37c55da View commit details
    Browse the repository at this point in the history