Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unicode emoji characters, allowing them to be customized by renderer rules #53

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

carter-thaxton
Copy link

A very straightforward implementation of #43. "It just works!"
I'm sure it's possible to provide an option to control this behavior, but it doesn't seem necessary.

Use enforced code style for spaces.
The code coverage checker was complaining about the 'unnecessary' check that I added in the previous commit, in case the replacement regexp didn't match anything.
Specifically, add a test that emojies using unicode characters are also wrapped by such renderer rules,
covering the new behavior in this pull request.
@carter-thaxton
Copy link
Author

I added some tests to cover this new behavior, and fixed the linter errors in my previous commit.
I'm happy to squash into a single commit, if you'd prefer. Just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant