Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Node's deprecated punycode #967

Closed
bcomnes opened this issue Oct 30, 2023 · 3 comments
Closed

Replace Node's deprecated punycode #967

bcomnes opened this issue Oct 30, 2023 · 3 comments

Comments

@bcomnes
Copy link

bcomnes commented Oct 30, 2023

Importing markdown-it into Node.js triggers a warning now:

node:11893) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.

Looks like anything relying on Node.js's punycode implementation should switch to a userland implementation.

var punycode = require('punycode');

Let me know if you want a PR.

@philoserf
Copy link

philoserf commented Nov 8, 2023

@philoserf
Copy link

Thank you. Most downstream users will not get an update until we tag/release.

@puzrin
Copy link
Member

puzrin commented Dec 2, 2023

#863 (comment) in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants