Fixes #126 #129
Merged
Fixes #126 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll be adding an equivalent method without the `-c` flag, so rename this for clarity.
added 6 commits
April 6, 2016 19:14
I'll be adding a method similar to `run_cli_with_rc_flag`, so I extract some methods so I can reuse them later.
If we do this, we never ascend because `ascend` needs an absolute path to work properly. Instead, only return early if the given file exists.
`p.join(CONFIG_FILE)` only makes sense for directories. So skip the first iteration of `ascend`, which is a file.
We want to check the existance of the rc file in the folder we are currently traversing, not of the default rc file.
|
Thanks, this looks awesome! |
|
Great, thank you! 😃 |
|
To confirm the fix, just tried this against byebug and it works. Regards! |
deivid-rodriguez
pushed a commit
to deivid-rodriguez/byebug
that referenced
this pull request
Apr 7, 2016
So we can use latest improvements but still get our custom configuration loaded (markdownlint/markdownlint#129).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.