Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #126 #129

Merged
merged 7 commits into from
Apr 6, 2016
Merged

Fixes #126 #129

merged 7 commits into from
Apr 6, 2016

Commits on Apr 6, 2016

  1. Rename run_cli 

    We'll be adding an equivalent method without the `-c` flag, so rename
this for clarity.
    David Rodríguez committed Apr 6, 2016
    Configuration menu
    Copy the full SHA
    c3d84d0 View commit details
    Browse the repository at this point in the history

  2. Extract a couple of methods 

    I'll be adding a method similar to `run_cli_with_rc_flag`, so I extract
some methods so I can reuse them later.
    David Rodríguez committed Apr 6, 2016
    Configuration menu
    Copy the full SHA
    6f7e01c View commit details
    Browse the repository at this point in the history

  3. ascend needs an absolute path

    David Rodríguez committed Apr 6, 2016
    Configuration menu
    Copy the full SHA
    2993763 View commit details
    Browse the repository at this point in the history

  4. Don't unconditionally return absolute paths 

    If we do this, we never ascend because `ascend` needs an absolute path
to work properly. Instead, only return early if the given file exists.
    David Rodríguez committed Apr 6, 2016
    Configuration menu
    Copy the full SHA
    299f377 View commit details
    Browse the repository at this point in the history

  5. Skip files when ascending 

    `p.join(CONFIG_FILE)` only makes sense for directories. So skip the
first iteration of `ascend`, which is a file.
    David Rodríguez committed Apr 6, 2016
    Configuration menu
    Copy the full SHA
    b84cea9 View commit details
    Browse the repository at this point in the history

  6. Fix check for file existance 

    We want to check the existance of the rc file in the folder we are
currently traversing, not of the default rc file.
    David Rodríguez committed Apr 6, 2016
    Configuration menu
    Copy the full SHA
    ec72f30 View commit details
    Browse the repository at this point in the history

  7. Bug #126 should now be fixed. Add regression test

    David Rodríguez committed Apr 6, 2016
    Configuration menu
    Copy the full SHA
    fa435e1 View commit details
    Browse the repository at this point in the history