Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styfle to admin #1148

Merged
merged 1 commit into from
Mar 21, 2018
Merged

styfle to admin #1148

merged 1 commit into from
Mar 21, 2018

Conversation

joshbruce
Copy link
Member

@joshbruce joshbruce commented Mar 21, 2018

@mention the contributor: @styfle

This is a recommendation to:

  • Change user type
  • Add a badge
  • Remove a badge

@styfle has done a lot of little things that have helped improve the contributor experience (including instructing and knowledge sharing with me).

If you're the one mentioned in this PR:

  • whether you will accept the badge or not; or,
  • whether you will or will not dispute the recommendation to remove

within 30 days (silence is consent at this point, can't have the pull requests page filled with PRs related to badges forever).

Note: All committers must approve via review before merging, the disapproving committer can simply close the PR.

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accept. However I probably won't be able to contribute more time than I already am now.

@joshbruce
Copy link
Member Author

LGTM! Done.

Note: @styfle I didn't make you an owner of the MarkedJS organization. Mainly because I'm not sure if that's something we should reserve for publishers. Let us know if there's something that you would like to do that would require that level of access to the org.

Otherwise, congratulations - and don't worry about more time commitment or anything. This is recognition for contributions and work to date - not a request for more of your time or energy. :)

@joshbruce joshbruce merged commit 6661fe5 into markedjs:master Mar 21, 2018
@joshbruce joshbruce mentioned this pull request Mar 22, 2018
6 tasks
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants