Add pagination support to transactions index endpoint #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The transactions index endpoint now requests multiple pages (all available) when multiple pages are present.
Fixes AB#296.
Types of changes
What types of changes does your code introduce to this repository?
Testing
Explain here how to run your unit tests, and explain how to execute manual testing.
Unit testing
Nope :(
Manual testing
Try
get_transactionsfunction for dataset with > 10,000 transactions and verify that returned data frame contains all transactions that are available.Further comments
n/a