-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QualityTest script type and contracts for it #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Some additional context. One test script has been created that implements this new contract of the SDK already, see this PR. That script is then executed by the script service, which encodes the output to JSON. This JSON output is then visualized in manager 2.0. For a dev version that visualizes the response see this page https://manager.dev.pricecypher.com/#/data_quality for dataset 'Demo 2.0'. Then click on 'Completeness' within the 'Data quality scorecard'. That should make the hierarchy of multiple results within elements within tests within a test suite clearer, I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Proposed changes
Add QualityTestScript contract and other contracts that can be used for implementing them. See readme for more details.
Fixes AB#383.
Types of changes
What types of changes does your code introduce to this repository?
Testing
Explain here how to run your unit tests, and explain how to execute manual testing.
Unit testing
n/a
Manual testing
Install using
Further comments
n/a