Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QualityTest script type and contracts for it #20

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

marijnvanderhorst
Copy link
Member

@marijnvanderhorst marijnvanderhorst commented Oct 20, 2022

Proposed changes

Add QualityTestScript contract and other contracts that can be used for implementing them. See readme for more details.

Fixes AB#383.

Types of changes

What types of changes does your code introduce to this repository?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing

Explain here how to run your unit tests, and explain how to execute manual testing.

Unit testing

n/a

Manual testing

Install using

pip install pricecypher-sdk==0.5.0rc2.dev0

Further comments

n/a

Copy link
Contributor

@levykort1 levykort1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@marijnvanderhorst
Copy link
Member Author

@EmielSchmeink

Some additional context. One test script has been created that implements this new contract of the SDK already, see this PR.

That script is then executed by the script service, which encodes the output to JSON. This JSON output is then visualized in manager 2.0. For a dev version that visualizes the response see this page https://manager.dev.pricecypher.com/#/data_quality for dataset 'Demo 2.0'. Then click on 'Completeness' within the 'Data quality scorecard'. That should make the hierarchy of multiple results within elements within tests within a test suite clearer, I think.

Copy link
Contributor

@EmielSchmeink EmielSchmeink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/pricecypher/encoders/JsonEncoder.py Show resolved Hide resolved
@marijnvanderhorst marijnvanderhorst merged commit a32415b into develop Nov 3, 2022
@marijnvanderhorst marijnvanderhorst deleted the feature/quality-test-scripts branch November 3, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants