Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox: selecting all items ignores disabled settings #11

Closed
waza-ari opened this issue Jan 23, 2018 · 3 comments
Closed

Checkbox: selecting all items ignores disabled settings #11

waza-ari opened this issue Jan 23, 2018 · 3 comments

Comments

@waza-ari
Copy link

When using a checkbox with disabled settings, the disabled option is ignored when using the "a" key to add all entries:

  • Create checkbox with at least one disabled entry
  • use the "a" key to select all entries
  • submit the question

Now, the result set will contain all entries instead of all excluding the disabled ones.

https://github.com/finklabs/whaaaaat/blob/dfc69f33e00db495991e60c2a5dc4e5a662b0bb9/whaaaaat/prompts/checkbox.py#L194

@markfink
Copy link
Owner

thank you for using whaaaaat and for submitting issues and PRs. I am traveling right now and I can not promise to take a look before the weekend. First impression of your PRs is great so I assume they pass the tests, too.
BTW, please be aware that prompt_toolkit is undergoing major changes right now so this might significantly impact whaaaaat in the future.

@waza-ari
Copy link
Author

thank you for writing and sharing the software! Sorry, but I have to withdraw the PRs again, looks like I got a little bit confused when creating the branches. Since I had to modify the same line for two fixes, the PRs include each other changes... I'm going to clean that up a little bit and then I'll resubmit the PR(s). Going to try the tests as well, however it looks like the're not working in my OS X environment...

I also fixed another issue, going to report it and submit the PR as well. Sorry for the confusion.

Hope you will find time to include the fixes at the weekend!

Thanks and regards
Daniel

@waza-ari
Copy link
Author

I re-submitted the PRs, now with correct content. I had to submit a combined PR for issues #9, #10 and #11, since the commits modify the same lines of code, thus this should avoid merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants