Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with value instead of name, improving support for disabled attribute #16

Merged
merged 3 commits into from
Feb 18, 2018

Conversation

waza-ari
Copy link

Fixes #9, #10 and #11

Since the commits are modifying the same line, I had to combine the PRs for the three issues.

Unfortunately, I cannot get the tests to work in my OS X dev environment. Could be something related to the coding?

  • values are now used instead of the display names to keep track of selected entries. Further, the values are returned instead of the names
  • when selecting all items, the disabled attribute is now taken into account
  • inverting now takes the disabled setting into account

@markfink markfink merged commit 9cf4ed9 into markfink:develop Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants