Symfony5 #179
Merged
Symfony5 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benji07
commented
Nov 29, 2019
| @@ -23,6 +23,8 @@ public function let(RefreshTokenAuthenticator $authenticator, RefreshTokenProvid | |||
| $ttlUpdate = false; | |||
| $providerKey = 'testkey'; | |||
|
|
|||
| $eventDispatcher->dispatch(Argument::any(), Argument::any())->willReturn(Argument::any()); | |||
There was a problem hiding this comment.
i don't understand why i need to add this line in the test for them to pass
There was a problem hiding this comment.
If i don't have this line test fail fait:
Gesdinet/JWTRefreshTokenBundle/Service/RefreshToken
34 - it refresh token
exception [err:TypeError("Return value of Double\EventDispatcherInterface\P110::dispatch() must be an object, null returned")] has been thrown.
|
phpspec/phpspec#1276 has been merged and released |
norkunas
reviewed
Dec 3, 2019
|
Please someone for merge? |
Co-Authored-By: Tomas Norkūnas <norkunas.tom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo