autoload should be 'no' #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right, so WordPress only sets autoload to |
…g it indefinite. * With the default options-table based transient cache, indefinitely stored transients are autoloaded. * By setting an expiration date in the far-future, it is *effectively* indefinite, but we get the benefit of no autoloading of what might be a very large options row. props to @YousefED for bringing the issue to my attention. fixes #10
|
How does f388488 look? |
|
Thanks for the quick fix, I'll test it on one of our websites. Just to be sure I think it would be smart to throw an error when the expiration is meant to be after a year, or set the WP expiration to $expiration+$oneyear to be safe. |
|
I like the idea of $expiration plus one year: that's a safer way of doing what I was intending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transients are stored in wp_options with autoload='yes'. This means if you're storing a lot of different TLC transients with a lot of data (e.g. fetching and caching many URLs), Wordpress will take long to load all the options with autoload='yes' (including the transients), which can cause performance issues.
I think it would be better to store the transients with autoload='no'. Unfortunately, I didn't see a quick fix, because the WordPress transients API only sets autoload when an explicit expiration is set.