Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CuracaoInvokable instantiates multiple invokables per route #23

Closed
markkolich opened this issue Apr 3, 2016 · 1 comment
Closed

CuracaoInvokable instantiates multiple invokables per route #23

markkolich opened this issue Apr 3, 2016 · 1 comment

Comments

@markkolich
Copy link
Owner

Doing some debugging, I realized that https://github.com/markkolich/curacao/blob/master/curacao/src/main/java/curacao/CuracaoInvokable.java#L83 news up an instance of an invokable once per route.

This is so wrong.

We need an internal cache that maps Map<Class<?>, Object> to keep track of invokables that we've already created so we don't create multiple instances wasting memory.

markkolich added a commit that referenced this issue Apr 3, 2016
markkolich added a commit that referenced this issue Apr 3, 2016
@markkolich
Copy link
Owner Author

Fixed in release 4.0.5:
https://github.com/markkolich/curacao/releases/tag/4.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant