Added an opt-in solution for issue #27 and made issue #9 significantly easier. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset solves two problems by adding a new setting that allows users to opt-in to use the "advanced" output file selector. This new selector is simply an OpenFileDialog instead of a terrible FolderBrowserDialog. The two problems that this new dialog solves are: (1) A custom file name can be added as requested by issue marklagendijk#27, and (2) It is much easier to edit the output folder with the OpenFileDialog because you can type/paste a file path (which helps a bit with issue marklagendijk#9).
|
@jmclocklin thanks! |
|
@jmclocklin tnx! I will have a look to see whether the opt-in is necessary, or whether it should just be changed to 'select output file'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset solves two problems by adding a new setting that allows
users to opt-in to use the "advanced" output file selector. This new
selector is simply an OpenFileDialog instead of a terrible
FolderBrowserDialog. The two problems that this new dialog solves are:
(1) A custom file name can be added as requested by issue #27, and (2)
It is much easier to edit the output folder with the OpenFileDialog
because you can type/paste a file path (which helps a bit with issue
#9).