Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Separate out the configuration part for unittesting in server_config.rb #469

Closed
peetkes opened this issue Jun 23, 2015 · 2 comments
Closed

Comments

@peetkes
Copy link
Contributor

peetkes commented Jun 23, 2015

In function build_config the configuration file is created as one big config element.
If might be handy to separate out the different parts in separate function so those separate functions can be override in app_specific.
So create a separate function that only handles unit-test specific replacements, and one specific for the triggers db and so on.
One use-case is when you have a D-node/E-node config where all your data is on the D-nodes and all your http-servers are on the E-nodes and you want to enable the unittest section. You want to override the assignment and forest-data-directory.
These override statements can be done in an override function in the app_specific.rb file

@grtjn
Copy link
Contributor

grtjn commented Jun 23, 2015

In a nutshell: you cannot control server, db, and forest creation for generated parts of ml-config, like schemas, triggers, test, rest. You could add properties to allow influencing them from properties files, but overriding function from app_specific might be an elegant approach as well.

We could also support both..

@grtjn grtjn added this to the 1.7.3 milestone Jun 23, 2015
grtjn added a commit to grtjn/roxy that referenced this issue Jun 30, 2015
dmcassel added a commit that referenced this issue Jul 8, 2015
Fixed #469: moved config snippets into overridable functions
@dmcassel
Copy link
Collaborator

dmcassel commented Jul 8, 2015

Fixed in dev

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants