Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Roxy no longer supports server-version < 7 since v1.7.1 #800

Closed
grtjn opened this issue Jun 9, 2017 · 7 comments
Closed

Roxy no longer supports server-version < 7 since v1.7.1 #800

grtjn opened this issue Jun 9, 2017 · 7 comments

Comments

@grtjn
Copy link
Contributor

grtjn commented Jun 9, 2017

Show a deprecation warning if someone uses server-version < 7, and print a reference to https://github.com/marklogic/roxy/wiki/Supported-MarkLogic-versions. We should add a list of latest Roxy release to work with each of the no-longer-supported versions to that wiki page..

@grtjn
Copy link
Contributor Author

grtjn commented Jun 9, 2017

Also prevent people from upgrading to latest, if server-version < 7, with printing ref to same wiki page.

@grtjn
Copy link
Contributor Author

grtjn commented Jun 9, 2017

I think we need stronger language. We still allow selecting server-version 5 and 6, but Roxy actually stopped working against those since v1.7.1. I ran a few tests for that, and made changes to https://github.com/marklogic/roxy/wiki/Supported-MarkLogic-versions accordingly..

@grtjn grtjn added bug and removed enhancement labels Jun 9, 2017
@grtjn grtjn changed the title Add deprecation warning for server-version < 7 Roxy no longer supports server-version < 7 since v1.7.1 Jun 9, 2017
@grtjn grtjn added this to the July 2017 milestone Jun 9, 2017
@RobertSzkutak
Copy link
Contributor

Sounds like we also need to go through and remove properties, functions and tests referencing these older versions

@grtjn
Copy link
Contributor Author

grtjn commented Jun 12, 2017

Warning is printed as part of PR #769, which also removes version options < 7 from shown options. I'm reluctant to bluntly refuse, maybe in later release..

@grtjn grtjn self-assigned this Jun 12, 2017
@grtjn
Copy link
Contributor Author

grtjn commented Jun 12, 2017

Let's limit to warnings, and guidance for now, and hold off on severe cleanup till a later release..

@RobertSzkutak
Copy link
Contributor

I think thats the way to go. I dont know to what extent older versions dont work. Perhaps some operations are ok.

RobertSzkutak added a commit that referenced this issue Jul 28, 2017
Fixed #800: refuse to upgrade for ML 6 and older
@RobertSzkutak
Copy link
Contributor

Fixed in dev

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants