This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
Fixed #650: make sure server-version gets defaulted properly in all cases #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grtjn
force-pushed
the
650-prompt-server-version
branch
from
d365aa7
to
31c64c2
Compare
|
There was a merge conflict, but I resolved that with git rebase.. |
|
To test this, run |
deploy/lib/server_config.rb
Outdated
| end | ||
| if server_version == 0 | ||
| puts "Defaulting to 8.." | ||
| server_version = 8 |
There was a problem hiding this comment.
Should we default to 9?
deploy/lib/server_config.rb
Outdated
| @@ -318,15 +318,19 @@ def self.initcpf | |||
| def self.prompt_server_version | |||
| if @@no_prompt | |||
| puts 'Required option --server-version=[version] not specified with valid value, | |||
| but --no-prompt parameter prevents prompting for password. Assuming 8.' | |||
| but --no-prompt parameter prevents prompting for password.' | |||
| server_version = 0 | |||
| else | |||
| puts 'Required option --server-version=[version] not specified with valid value. | |||
|
|
|||
| What is the version number of the target MarkLogic server? [5, 6, 7, 8, or 9]' | |||
There was a problem hiding this comment.
Change this to only say 7, 8, or 9? Perhaps throw an error or warning if something lower than 7 is used?
|
Makes sense, I'll look into it tomorrow.. |
grtjn
force-pushed
the
650-prompt-server-version
branch
from
31c64c2
to
e6f72cc
Compare
|
What do you think of this? The warning is printed each time a command with an env is used if I am not mistaken. Should we add an option to silence the warning? The one for old Ruby is also always shown I think.. |
|
Looks good to me! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #650