This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
Fix for issue #621 #658
Merged
Fix for issue #621 #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for { and }, but doesn't look like it addresses <, >, , or /. |
|
Hi @dmcassel , in my testing I tried this as appuser-password "pm_5_#W>{[T,e}STojT<5" (no quotes) and it failed before but worked fine after the change. I tried a couple of other variants as well. Do you happen to have a password it didn't work for that I could try? The only outstanding issue I was aware of is that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#621
I tested this with a variety of passwords including many special characters such as
{ } >< \ /Ran many tests across Roxy and couldn't find any evidence that this breaks anything.
Simple fix but took me a couple evenings to study the codebase to find it and a couple more to thoroughly test it.
Partially fixes #622 but characters like
>and<are still shown as escaped. Probably will need a separate PR for that.