Fixed #500: linking sample tasks to bootstrap host by default #785
Conversation
deploy/lib/server_config.rb
Outdated
| @@ -104,6 +104,9 @@ def initialize(options) | |||
| else | |||
| @qconsole_port = @bootstrap_port | |||
| end | |||
|
|
|||
| r = execute_query %Q{xdmp:host-name()} | |||
| @properties["ml.server-name"] = parse_body(r.body) | |||
There was a problem hiding this comment.
Seems like this would also have the side effect of not allowing people to hit their load balancer? Couldn't that potentially be unwanted behavior for tools like MLCP?
There was a problem hiding this comment.
Can you elaborate? Keep in mind server-name is only used within ml-config. We will remain using ml.server to make http/xcc calls..
There was a problem hiding this comment.
You're correct, I confused the two properties
|
Yeah, the ml.server-name property is new, and not read from properties yet. I could add that though, as option. And I need to make the xqy call a bit more robust. (capture exceptions if ml cannot be reached or such..) |
|
This is fine for me. Appeared to work correctly and didnt seem to break anything. |
Fixes #500