This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
First stab at #808: accept unwrapped config parts, replace ml-config.xml with ml-config/ #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm probably going to solve #692 first, and leverage that work in here.. |
grtjn
force-pushed
the
808-config-parts
branch
2 times, most recently
from
aa586fc
to
1e9d4cd
Compare
grtjn
commented
Jun 15, 2017
| @@ -31,7 +31,7 @@ modules-prefix=/ | |||
| # | |||
| # the location of your marklogic configuration file | |||
| # | |||
| # config.file=${basedir}/deploy/ml-config.xml | |||
| config.file=${basedir}/deploy/ml-config/ | |||
There was a problem hiding this comment.
I think I'm going to undo this. I like the idea better to start with ml-config.xml, and have people split it themselves for now..
|
Getting somewhere! |
|
PR #812 should be merged first.. |
… replace ml-config.xml with ml-config/
… existing ml-config.xml into parts
…able to expose decision logic within ml-config
grtjn
force-pushed
the
808-config-parts
branch
from
5816fba
to
3fd8f05
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, don't merge yet!
First stab at fixing #808. Feedback appreciated!