Deleting an entity deletes associated flows and code without warning or confirmation #578
Comments
|
@dmcassel, @damonfeldman, and @popzip , I've added an additional modal dialog box so that the user will have to press "Yes" twice before we delete the entity and all associated flows and code. Are there specific checks that we would want to perform? I've made the changes to the current "develop" branch, should this change be made to the 1.0 and 2.0 branches as well? Here's the original dialog message that is currently in the develop branch that I'm leaving unchanged: When a user presses the "Yes" button, then the new dialog box will appear like the following: If the user presses "Yes" to the new dialog box, then it will proceed with deleting the entity and all associated flows and code. If the user presses "No" to the second modal window, then it will NOT delete anything. I just wanted to double check this implementation to make sure I'm not missing anything within the scope of this ticket. |
|
We would like to separate entities from flows so that each are top-level classes in DHF. As we plan for architectural changes in summertime this will be one issue we address. |
|
@grechaw, thank you for the clarification for the changes coming up in the 3.0 branch. Is the plan that 1.0 and 2.0 would have the entities and flows separated as well? I'm trying to wrap my head around if there is any portion of this task that can be done now in terms of a warning/confirmation, or will all of this become moot with the future changes? |
|
We're not likely to go back to 2 or 1 to separate the flows -- all our work is in the 3 branch now. |
|
@grechaw, thanks for the updates. So it seems like I can scrap the code for the 3.0/develop branch then since these are going to be split out during the summer. Is there value in me adding the additional dialogs to the 1.0/2.0 branches now since the flows aren't going to be separated in the future? Or I can scrap this code altogether and leave this ticket in the backlog so that it can be addressed when the entities and flows are split out. |
|
I'd like to leave this bug open until it's resolved. As for 2 branch, a dialog might be a good response. Feel free to submit a PR, we can look at doing a 2.0 branch maintenance release if product team feels its a good idea. We do think that migrating to 3.0 will make you happier though. |
|
Great thanks again @grechaw! I'll create a PR for the 2.0 develop branch. Thanks again for all of your input! |
Adding an additional dialog message to the 2.0 development branch that will require the user to press yes twice before the entity and all associated flows and code are deleted
|
Thanks @mhuang-ml |
|
If the code is written its not a bad idea to add to 3.1 is it? |
|
Yeah, let's slot it for 3.1 as well to cover the gap before we split out entities/flows. |
|
➤ Scott Brooks commented: Code change handled by Michael Huang Setting status to In Review |
Adding an additional dialog message to the 2.0 development branch that will require the user to press yes twice before the entity and all associated flows and code are deleted
|
➤ Charles Greer commented: This is in a PR from the community |
|
➤ Scott Brooks commented: I went ahead and created the PR for the develop branch with your fix @mhuang-ml. See: #917 |
|
➤ Scott Brooks commented: Video capturing change: https://drive.google.com/file/d/155e9TfhcWecL1yrNN5-8umEctsPUFa8L/view |
Adding an additional dialog message to the 2.0 development branch that will require the user to press yes twice before the entity and all associated flows and code are deleted
|
➤ Scott Brooks commented: Change merged into develop branch. Passing to QA. |
|
Sorry I’m late to the party here. I don’t think we need to double up on the confirmation dialog boxes. I think adding clearer messaging to the existing dialog about what all is deleted along with the entity is sufficient. I also think we don’t need to say “code,” if by code we mean plugins, since the plugins are simply the building blocks of the flows. (I may be wrong. Maybe there is additional important "code" that goes away, in which case we should say what.) —————— Any flows associated with the NO YES |
|
I agree with Mike's suggestion. Two dialog boxes are redundant |
Removing the double confirmation dialog and updating the deletion message that is displayed to the user to make it clearer to what they are deleting.
* DHFPROD-496 fix QuickStart naming in app “QuickStart”, not “Quick Start” * DHFPROD-497 fix property index selection Add flags to property to keep track of what indexes are set (instead of using name). Set flags based on entity state when editor opens. Set entity state based on flags on save. * Fixes #582 - should be reviewed for UX before merging. (#906) * Fix tab bar layout issue #798 (#909) * Rework of fix for issue #557 where URI in request to /doc API (#915) Now matches other implementations throughout codebase which leverage encodeURIComponent() * Fixing Issue #578: Adding deletion dialog (#889) (#917) Adding an additional dialog message to the 2.0 development branch that will require the user to press yes twice before the entity and all associated flows and code are deleted * DHFPROD-664 adjust offset, size of new entities in UI (#918)
Removing the double confirmation dialog and updating the deletion message that is displayed to the user to make it clearer to what they are deleting.
* DHFPROD-496 fix QuickStart naming in app “QuickStart”, not “Quick Start” * DHFPROD-497 fix property index selection Add flags to property to keep track of what indexes are set (instead of using name). Set flags based on entity state when editor opens. Set entity state based on flags on save. * Fixes #582 - should be reviewed for UX before merging. (#906) * Fix tab bar layout issue #798 (#909) * Rework of fix for issue #557 where URI in request to /doc API (#915) Now matches other implementations throughout codebase which leverage encodeURIComponent() * Fixing Issue #578: Adding deletion dialog (#889) (#917) Adding an additional dialog message to the 2.0 development branch that will require the user to press yes twice before the entity and all associated flows and code are deleted * DHFPROD-664 adjust offset, size of new entities in UI (#918) * Updating Issue #578: Update the deletion message (#919) Removing the double confirmation dialog and updating the deletion message that is displayed to the user to make it clearer to what they are deleting.
Removing the double confirmation dialog and updating the deletion message that is displayed to the user to make it clearer to what they are deleting.
Removing the double confirmation dialog and updating the deletion message that is displayed to the user to make it clearer to what they are deleting.
Removing the double confirmation dialog and updating the deletion message that is displayed to the user to make it clearer to what they are deleting.
Removing the double confirmation dialog and updating the deletion message that is displayed to the user to make it clearer to what they are deleting.
Adding an additional dialog message to the 2.0 development branch that will require the user to press yes twice before the entity and all associated flows and code are deleted
Removing the double confirmation dialog and updating the deletion message that is displayed to the user to make it clearer to what they are deleting.
Deleting an entity should have more warnings or safety. Could be an enhancement but I'll put this in as a bug.
Hub Version
2.0
The text was updated successfully, but these errors were encountered: