DHFPROD-1693 Use CMA with ml-gradle 3.11 #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinathgit
reviewed
Jan 21, 2019
marklogic-data-hub/src/main/java/com/marklogic/hub/deploy/commands/DeployHubAmpsCommand.java
Show resolved
Hide resolved
srinathgit
reviewed
Jan 21, 2019
| if (serverVersion.matches("^[9]\\.0-([6789]|[0-9]{2,})(\\.\\d+)?")) { | ||
| // only on 9.0-5 are amps uninstalled at all. | ||
| logger.warn("Amps from uninstalled data hub framework to remain, but are disabled."); | ||
| super.execute(context); |
There was a problem hiding this comment.
We used to uninstall amps in 9.0-5 and not in any other version. Now it looks like we are uninstalling in all other versions except 9.0-5 ?
There was a problem hiding this comment.
Yeah, let's make sure that we're consistent in the uninstallation of amps.
There was a problem hiding this comment.
Now checking for "-SNAPSHOT" to determine if amps are uninstalled.
There was a problem hiding this comment.
This should split the middle between wanting one path to handle amps, while also not slowing our tests to a crawl. @srinathgit good for you?
srinathgit
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.