Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language parameter to mlGenerateUnitTestSuite #643

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

dmcassel
Copy link
Contributor

@dmcassel dmcassel commented Jan 5, 2023

Added a -Planguage parameter to the mlGenerateUnitTestSuite task. Accepts either "sjs" or "xqy". It looks for "sjs" and generates a JavaScript test suite if it matches; otherwise assumes XQuery. Also assumes XQuery if the parameter is missing (to maintain previous behavior).

@dmcassel
Copy link
Contributor Author

dmcassel commented Jan 5, 2023

@rjrudin please review as an implementation of #511.

@dmcassel
Copy link
Contributor Author

dmcassel commented Jan 5, 2023

Testing: I generated a test suite using -Planguage=sjs, -Planguage=xqy, and no language parameter. In each case I deployed and ran the test. They ran correctly.

@rjrudin
Copy link
Contributor

rjrudin commented Jan 10, 2023

Thanks @dmcassel ! Will get to this soon, we're making plans for a 4.5.0 release in the next 2 or 3 weeks and will definitely address this.

@rjrudin rjrudin added this to the 4.5.0 milestone Jan 10, 2023
Copy link
Contributor

@rjrudin rjrudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I tested it out after rebasing it off dev, and the generated sjs (and xqy) tests all pass after being created.

Can you rebase this off dev and then squash the two commits together? I'll then approve and merge.

@dmcassel
Copy link
Contributor Author

dmcassel commented Feb 3, 2023

Can you rebase this off dev and then squash the two commits together? I'll then approve and merge.

done

@rjrudin rjrudin merged commit 86bcd43 into marklogic:dev Feb 3, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants