puts a warning behind the verbose option, closes #138

markmfredrickson · May 14, 2018 · f6ef7f5 · f6ef7f5
1 parent 9e1600b
commit f6ef7f5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/R/fullmatch.R b/R/fullmatch.R
@@ -552,7 +552,10 @@ fullmatch.matrix <- function(x,
     attr(mout, "omit.fraction") <- out.omit.fraction
   }
 
-  if(length(new.omit.fraction) > 0 & !identical(new.omit.fraction, omit.fraction) & !all(is.na(new.omit.fraction))) {
+  if(length(new.omit.fraction) > 0 &
+     !identical(new.omit.fraction, omit.fraction) &
+     !all(is.na(new.omit.fraction)) &
+     getOption("optmatch_verbose_messaging", FALSE)) {
     if(!any(is.na(new.omit.fraction)) & all(new.omit.fraction == 1)) {
       # If we never got a feasible subproblem
       warning("The problem appears infeasible with the given constraints.")

diff --git a/tests/testthat/test.fullmatch.infeasible.recovery.R b/tests/testthat/test.fullmatch.infeasible.recovery.R
@@ -110,6 +110,8 @@ test_that("Allow passing all NA to mean.controls or omit.fraction", {
 })
 
 test_that("Correctly apply max.controls", {
+  options("optmatch_verbose_messaging" = TRUE)
+
   set.seed(2)
   x <- runif(20)
   fact <- c(rep(0,7), rep(1, 4), rep(2, 9))
@@ -149,6 +151,7 @@ test_that("Correctly apply max.controls", {
 })
 
 test_that("Omits occur only on controls", {
+  options("optmatch_verbose_messaging" = TRUE)
   set.seed(3)
   x <- runif(20)
   fact <- c(rep(0,7), rep(1, 4), rep(2, 9))