fix: false values are removed from style string. closes #1692 (#1693)

marko-js · May 14, 2021 · ac140d4 · ac140d4
1 parent 5de6157
commit ac140d4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/marko/src/runtime/helpers/style-value.js b/packages/marko/src/runtime/helpers/style-value.js
@@ -23,7 +23,7 @@ module.exports = function styleHelper(style) {
     } else if (type === "object") {
       for (var name in style) {
         var value = style[name];
-        if (value != null) {
+        if (value != null && value !== false) {
           if (typeof value === "number" && value) {
             value += "px";
           }

diff --git a/packages/marko/test/render/fixtures/style-attr-object/template.marko b/packages/marko/test/render/fixtures/style-attr-object/template.marko
@@ -1 +1 @@
-div style={color: 'red', fontWeight: 'bold', 'background-color':'blue'}
+div style={color: 'red', margin: false, fontWeight: 'bold', 'background-color':'blue'}