Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: false values are removed from style string. closes #1692 #1693

Merged
merged 1 commit into from
May 14, 2021

Conversation

mlrawlings
Copy link
Member

Description

<div style={ display: "block", color: false, marginRight: 16 }>

Old output

<div style="display:block;color:false;margin-right:16px;">

New output

<div style="display:block;margin-right:16px;">

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #1693 (03946b1) into main (5de6157) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1693   +/-   ##
=======================================
  Coverage   90.43%   90.43%           
=======================================
  Files         222      222           
  Lines        6733     6733           
=======================================
  Hits         6089     6089           
  Misses        644      644           
Impacted Files Coverage Δ
packages/marko/src/runtime/helpers/style-value.js 95.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5de6157...03946b1. Read the comment docs.

@mlrawlings mlrawlings merged commit ac140d4 into main May 14, 2021
@DylanPiercey DylanPiercey deleted the issue-1692 branch January 8, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant