-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format + lint #1016
Format + lint #1016
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1016 +/- ##
==========================================
- Coverage 90.37% 90.36% -0.02%
==========================================
Files 304 304
Lines 11536 11518 -18
==========================================
- Hits 10426 10408 -18
Misses 1110 1110
Continue to review full report at Codecov.
|
Congrats on this! Nice to see some modern tooling going into the project 👍 🌟 I just wish you had used a 2 space tab width and single quotes... 😓 |
@maxmilton We made the decision to just use the prettier defaults, however, it seems our @marko-js/core Do we want to remove the As far as the single quotes, it looks like prettier may default to that in 2.0. We could go ahead and make the change now to avoid thrashing commits later... or we could wait. Thoughts? |
Ah, I was wondering where the config came from! I didn't realise prettier will pick up The other option that looks like it will change is |
Switch to
eslint
and addprettier
Here's a link to the diff prior to running prettier:
https://github.com/marko-js/marko/compare/d7e529d401078817ee9cd4ab8887de9458956b4e