Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format + lint #1016

Merged
merged 16 commits into from
Mar 9, 2018
Merged

Format + lint #1016

merged 16 commits into from
Mar 9, 2018

Conversation

mlrawlings
Copy link
Member

Switch to eslint and add prettier

Here's a link to the diff prior to running prettier:
https://github.com/marko-js/marko/compare/d7e529d401078817ee9cd4ab8887de9458956b4e

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 90.363% when pulling dcae2cc on format-lint into ee17aa5 on master.

@coveralls
Copy link

coveralls commented Mar 8, 2018

Coverage Status

Coverage decreased (-0.02%) to 90.363% when pulling 789cbd1 on format-lint into ee17aa5 on master.

@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #1016 into master will decrease coverage by 0.01%.
The diff coverage is 88.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
- Coverage   90.37%   90.36%   -0.02%     
==========================================
  Files         304      304              
  Lines       11536    11518      -18     
==========================================
- Hits        10426    10408      -18     
  Misses       1110     1110
Impacted Files Coverage Δ
...ponents/taglib/TransformHelper/handleLegacyBind.js 88.33% <ø> (-0.73%) ⬇️
src/components/taglib/components-transformer.js 93.02% <ø> (ø) ⬆️
src/components/taglib/helpers/bindComponent.js 0% <ø> (ø) ⬆️
src/components/index.js 98.68% <ø> (ø) ⬆️
src/components/endComponent-browser.js 100% <ø> (ø) ⬆️
src/morphdom/specialElHandlers.js 84.84% <ø> (-0.87%) ⬇️
src/components/ready.js 53.84% <ø> (ø) ⬆️
src/compiler/util/parseJavaScript.js 81.87% <ø> (ø) ⬆️
src/components/beginComponent.js 100% <ø> (ø) ⬆️
src/components/taglib/preserve-tag-browser.js 100% <ø> (ø) ⬆️
... and 392 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee17aa5...789cbd1. Read the comment docs.

@DylanPiercey DylanPiercey self-requested a review March 9, 2018 17:46
@DylanPiercey DylanPiercey merged commit 0f5e639 into master Mar 9, 2018
@DylanPiercey DylanPiercey deleted the format-lint branch March 10, 2018 00:32
@maxmilton
Copy link

maxmilton commented Mar 12, 2018

Congrats on this! Nice to see some modern tooling going into the project 👍 🌟

I just wish you had used a 2 space tab width and single quotes... 😓

@mlrawlings
Copy link
Member Author

@maxmilton We made the decision to just use the prettier defaults, however, it seems our .editorconfig has a tab width set and prettier is picking that up.

@marko-js/core Do we want to remove the .editorconfig and reformat or leave as is? I
don't have a preference myself.

As far as the single quotes, it looks like prettier may default to that in 2.0. We could go ahead and make the change now to avoid thrashing commits later... or we could wait. Thoughts?

@maxmilton
Copy link

Ah, I was wondering where the config came from! I didn't realise prettier will pick up .editorconfig files when there's no explicitly set value.

The other option that looks like it will change is trailingComma defaulting to es5 which would also make a big impact on this codebase. I say make the changes now but I'll leave that up to the core team 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants