Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert imperative rendering inside scriptlets to dynamic tags #1174

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

DylanPiercey
Copy link
Contributor

Description

This builds on top of #1165 and adds the same imperative rendering => dynamic tag transform within scriptlets where possible. This does not account for every scenario but the most prominent ones.

  1. $ input.renderBody(out) => <${input}/>
  2. $ input.renderThing(out) => <${input.renderThing}/>
  3. $ input.renderBody(out, attrs) => <${input} ...attrs/>
  4. $ renderBody(out) => <${renderBody}/>
  5. $ input.template.render({}, out) => <${input.template} ...{}/>
  6. $ input.template.renderer({}, out) => <${input.template} ...{}/>
  7. $ input.barRenderer({}, out) => <${{ render:input.barRenderer }} ...{}/>
  8. $ input.barRenderer({}, true, out) => <${(out) => input.barRenderer({}, true, out)}/>

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@DylanPiercey DylanPiercey force-pushed the scriptlet-imperative-rendering-migration branch from 2f042ef to 90b01c7 Compare November 26, 2018 18:01
@DylanPiercey DylanPiercey force-pushed the scriptlet-imperative-rendering-migration branch from 90b01c7 to ae64f39 Compare November 26, 2018 18:02
@coveralls
Copy link

coveralls commented Nov 26, 2018

Coverage Status

Coverage increased (+0.1%) to 90.537% when pulling ae64f39 on scriptlet-imperative-rendering-migration into 3e6b954 on master.

@codecov
Copy link

codecov bot commented Nov 26, 2018

Codecov Report

Merging #1174 into master will increase coverage by 0.09%.
The diff coverage is 97.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1174      +/-   ##
==========================================
+ Coverage   90.43%   90.53%   +0.09%     
==========================================
  Files         311      313       +2     
  Lines       11827    11899      +72     
==========================================
+ Hits        10696    10773      +77     
+ Misses       1131     1126       -5
Impacted Files Coverage Δ
src/taglibs/core/util/renderCallToDynamicTag.js 100% <100%> (ø)
src/taglibs/core/invoke-tag.js 80.95% <100%> (-6.93%) ⬇️
src/compiler/util/parseJavaScript.js 85.31% <100%> (+2.39%) ⬆️
src/taglibs/core/root-transformer.js 94.28% <94.28%> (ø)
src/compiler/ast/Macro.js 94.44% <0%> (+5.55%) ⬆️
src/compiler/ast/HtmlComment.js 76.47% <0%> (+5.88%) ⬆️
src/compiler/ast/ContainerNode.js 100% <0%> (+16.66%) ⬆️
src/compiler/ast/ElseIf.js 85.71% <0%> (+21.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e6b954...ae64f39. Read the comment docs.

@DylanPiercey DylanPiercey merged commit 3954256 into master Nov 26, 2018
@DylanPiercey DylanPiercey deleted the scriptlet-imperative-rendering-migration branch November 30, 2018 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants