Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dynamic attribute priority #1223

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Conversation

mlrawlings
Copy link
Member

Description

No matter where the dynamic ${attrs} are defined, they always have lowest priority. In the following example, both explicit foo and bar attributes would overwrite any values in attrs.

<div foo=123 ${attrs} bar=456>Hello World</div>

The current migration gives highest priority to these dynamic attributes rather than lowest.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #1223 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1223      +/-   ##
==========================================
+ Coverage   90.57%   90.58%   +<.01%     
==========================================
  Files         333      334       +1     
  Lines       12235    12244       +9     
==========================================
+ Hits        11082    11091       +9     
  Misses       1153     1153
Impacted Files Coverage Δ
src/taglibs/migrate/all-tags/dynamic-attributes.js 100% <100%> (ø) ⬆️
src/taglibs/migrate/all-tags/widget-elId.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aef04be...3bd5fa8. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0008%) to 90.577% when pulling 3bd5fa8 on dynamic-attribute-priority into aef04be on master.

@mlrawlings mlrawlings merged commit 89368b0 into master Jan 7, 2019
@DylanPiercey DylanPiercey deleted the dynamic-attribute-priority branch July 8, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants