Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix <html-comment> tag #1261

Merged
merged 1 commit into from
Feb 15, 2019
Merged

fix <html-comment> tag #1261

merged 1 commit into from
Feb 15, 2019

Conversation

mlrawlings
Copy link
Member

Description

<html-comment> now works in vdom output and supports placeholders

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #1261 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1261   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files         337      337           
  Lines       12370    12370           
=======================================
  Hits        11194    11194           
  Misses       1176     1176
Impacted Files Coverage Δ
src/taglibs/html/html-comment-tag.js 100% <100%> (ø) ⬆️
src/runtime/html/AsyncStream.js 90.15% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe194d...62096ca. Read the comment docs.

@DylanPiercey DylanPiercey merged commit d2a0de5 into master Feb 15, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.493% when pulling 62096ca on fix-html-comment into bfe194d on master.

@DylanPiercey DylanPiercey deleted the fix-html-comment branch July 8, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants