Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with hydrating nested fragments that are adjacent in the dom #1294

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

DylanPiercey
Copy link
Contributor

Description

Currently in situations where there are nested fragments that are siblings it is possible that a fragment will find the incorrect ending marker which can cause strange behavior after hydrating.

This PR resolves the issue by keeping track of the number of open fragments discovered while looking for the end marker.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #1294 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1294      +/-   ##
==========================================
+ Coverage   90.53%   90.54%   +<.01%     
==========================================
  Files         339      339              
  Lines       12403    12411       +8     
==========================================
+ Hits        11229    11237       +8     
  Misses       1174     1174
Impacted Files Coverage Δ
src/components/Component.js 95.28% <ø> (-0.02%) ⬇️
src/morphdom/index.js 98.04% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856185d...f64de9a. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 90.541% when pulling f64de9a on fix-nested-adjacent-fragments into 856185d on master.

@DylanPiercey DylanPiercey merged commit 070b09b into master Mar 19, 2019
@DylanPiercey DylanPiercey deleted the fix-nested-adjacent-fragments branch July 8, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants