Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that we have a correct stack trace during async rendering in dev #1453

Merged
merged 1 commit into from Nov 18, 2019

Conversation

ccinelli
Copy link
Contributor

@ccinelli ccinelli commented Nov 15, 2019

Description

Fix #1312

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Chris Cinelli seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #1453 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1453      +/-   ##
==========================================
+ Coverage   90.57%   90.57%   +<.01%     
==========================================
  Files         344      344              
  Lines       12608    12611       +3     
==========================================
+ Hits        11420    11423       +3     
  Misses       1188     1188
Impacted Files Coverage Δ
src/core-tags/core/await/renderer.js 98.98% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0414fe8...7fa1282. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 15, 2019

Coverage Status

Coverage increased (+0.002%) to 90.58% when pulling 7fa1282 on ccinelli:feature/cc/async-trace into 0414fe8 on marko-js:master.

@mlrawlings mlrawlings merged commit a8656de into marko-js:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error messages (show where error is)
5 participants