Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that we have a correct stack trace during async rendering in dev #1453

Merged
merged 1 commit into from Nov 18, 2019
Merged

Make sure that we have a correct stack trace during async rendering in dev #1453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/core-tags/core/await/renderer.js
View file
Open in desktop
Expand Up @@ -50,10 +50,19 @@ function requestData(provider, timeout) {
timeout = 10000;
}

var error;
var errorMsg = "Timed out after " + timeout + "ms";
// eslint-disable-next-line no-constant-condition
if ("MARKO_DEBUG") {
// Make sure we have a meaningful stack trace in development preparing the stacktrace upfront.
// If we create it inside the setTimeout, we will end up with a short, not meaningful, stack trace
// We only do it in development to avoid overhead in production
error = new Error(errorMsg);
}
if (timeout > 0) {
let timeoutId = setTimeout(function() {
timeoutId = null;
var error = new Error("Timed out after " + timeout + "ms");
if (!error) error = new Error(errorMsg);
error.code = "ERR_AWAIT_TIMEDOUT";
error.name = "TimeoutError";
asyncValue.___reject(error);
Expand Down