Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize template literal printing in html mode #2286

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

DylanPiercey
Copy link
Contributor

Description

  • Optimize the printing of template literals in the compiled html output. This now merges the static content from template literals with the rest of native tag html and reduces the amount of escaping needed.
  • Avoid passing template literals through to the merge style/class helpers since we already know their strings.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 3623b48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@marko/translator-default Patch
@marko/compiler Patch
marko Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey merged commit 55338b5 into main Aug 29, 2024
7 checks passed
@DylanPiercey DylanPiercey deleted the template-literal-optimization branch August 29, 2024 18:03
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.99%. Comparing base (e7eb9c3) to head (3623b48).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2286      +/-   ##
==========================================
+ Coverage   87.97%   87.99%   +0.01%     
==========================================
  Files         337      337              
  Lines       35133    35164      +31     
  Branches     2085     2085              
==========================================
+ Hits        30909    30942      +33     
+ Misses       4208     4206       -2     
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant