Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asyncfragment info #305

Merged
merged 4 commits into from
Jun 9, 2016
Merged

Asyncfragment info #305

merged 4 commits into from
Jun 9, 2016

Conversation

mlrawlings
Copy link
Member

  • Adds additional event info (finished/timedout) to the data emitted from tags.
  • Ensures that renderBody() is not called again if the fragment has already finished (timed out).
  • Fixes npm run test-async
  • Removes a redundant async-fragment timeout related test

@coveralls
Copy link

coveralls commented Jun 9, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 83.434% when pulling 5c7eb27 on mlrawlings:asyncfragment-info into 06f6e37 on marko-js:master.

@patrick-steele-idem patrick-steele-idem merged commit f22b8b3 into marko-js:master Jun 9, 2016
@patrick-steele-idem
Copy link
Contributor

Thanks for the PR! New version published with fixes/improvements: marko@3.4.7

Still need to back port to Marko v2

patrick-steele-idem added a commit to marko-js-archive/marko-async that referenced this pull request Jun 9, 2016
@patrick-steele-idem
Back ported marko-js/marko#305 to Marko v2
2630171
@patrick-steele-idem
Copy link
Contributor

Fix back ported to Marko v2. New version of Marko v2 published: marko-async@2.2.2

@mlrawlings mlrawlings deleted the asyncfragment-info branch June 9, 2016 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlrawlings @coveralls @patrick-steele-idem