Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes issue 658 by removing empty style blocks #715

Merged
merged 2 commits into from
Jun 2, 2017
Merged

fixes issue 658 by removing empty style blocks #715

merged 2 commits into from
Jun 2, 2017

Conversation

mlrawlings
Copy link
Member

Checklist:

  • My code follows the code style of this project.
  • I have updated/added documentation affected by my changes. N/A
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I think we also need to make a change on the lasso side: If code is an empty string, it doesn't use it and instead tries to read from the filesystem.

@coveralls
Copy link

coveralls commented Jun 1, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 89.529% when pulling 4a5468c on issue-658 into eb811da on master.

@coveralls
Copy link

coveralls commented Jun 1, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 89.529% when pulling 4a5468c on issue-658 into eb811da on master.

@austinkelleher austinkelleher self-requested a review June 2, 2017 16:29
austinkelleher
austinkelleher approved these changes Jun 2, 2017
View reviewed changes
Copy link
Member

@austinkelleher austinkelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mlrawlings mlrawlings merged commit 5c2f626 into master Jun 2, 2017
@mlrawlings mlrawlings deleted the issue-658 branch August 22, 2017 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinkelleher austinkelleher austinkelleher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlrawlings @coveralls @austinkelleher